Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

V4L/DVB (6784): tda8290: prevent possible memory leak

Browse source 
Always call tda829x_release if tda829x_attach fails for a reason
other than failure to allocate memory for private structure.

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
This commit is contained in:
Michael Krufky 2007-12-09 05:16:10 -03:00 committed by Mauro Carvalho Chehab
parent c7919d520f
commit fa746aee33
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/media/video/tda8290.c
View file

@ -704,7 +704,7 @@ int tda829x_attach(struct tuner *t)
}
if (tda829x_find_tuner(fe) < 0)
return -EINVAL;
goto fail;
if (priv->ver & TDA8290) {
tda8290_init_tuner(fe);
@ -717,6 +717,11 @@ int tda829x_attach(struct tuner *t)
t->mode = V4L2_TUNER_ANALOG_TV;
return 0;
fail:
tda829x_release(fe);
fe->ops.analog_demod_ops = NULL;
return -EINVAL;
}
EXPORT_SYMBOL_GPL(tda829x_attach);