Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

bpf: make function skip_callee static and return NULL rather than 0

Browse source 
Function skip_callee is local to the source and does not need to
be in global scope, so make it static. Also return NULL rather than 0.
Cleans up two sparse warnings:

symbol 'skip_callee' was not declared. Should it be static?
Using plain integer as NULL pointer

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
This commit is contained in:
Colin Ian King 2017-12-18 17:47:07 +00:00 committed by Daniel Borkmann
parent e90004d56b
commit fa2d41adb9
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
kernel/bpf/verifier.c
View file

@ -823,6 +823,7 @@ static int check_subprogs(struct bpf_verifier_env *env)
return 0; return 0;
} }
static
struct bpf_verifier_state *skip_callee(struct bpf_verifier_env *env, struct bpf_verifier_state *skip_callee(struct bpf_verifier_env *env,
const struct bpf_verifier_state *state, const struct bpf_verifier_state *state,
struct bpf_verifier_state *parent, struct bpf_verifier_state *parent,
@ -867,7 +868,7 @@ struct bpf_verifier_state *skip_callee(struct bpf_verifier_env *env,
verbose(env, "verifier bug regno %d tmp %p\n", regno, tmp); verbose(env, "verifier bug regno %d tmp %p\n", regno, tmp);
verbose(env, "regno %d parent frame %d current frame %d\n", verbose(env, "regno %d parent frame %d current frame %d\n",
regno, parent->curframe, state->curframe); regno, parent->curframe, state->curframe);
return 0; return NULL;
} }
static int mark_reg_read(struct bpf_verifier_env *env, static int mark_reg_read(struct bpf_verifier_env *env,