Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback

Browse source 
Network device TX is never run in IRQ context, and skb is freed outside
of the IRQ-disabling spin lock. So checking for IRQ was a waste of time
here.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Rémi Denis-Courmont 2009-06-01 01:18:55 +00:00 committed by David S. Miller
parent bbd5898d39
commit fa20259279
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/usb/gadget/f_phonet.c
View file

@ -255,7 +255,7 @@ static int pn_net_xmit(struct sk_buff *skb, struct net_device *dev)
spin_unlock_irqrestore(&port->lock, flags);
out:
if (unlikely(skb)) {
dev_kfree_skb_any(skb);
dev_kfree_skb(skb);
dev->stats.tx_dropped++;
}
return 0;