Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

PCI: iproc: Validate CSR base in BCMA setup code

Browse source 
Validate iproc_pcie->base for BCMA devices just like we already do for
platform devices in iproc_pcie_pltfm_probe().  No functional change
intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Bjorn Helgaas 2016-10-06 13:36:07 -05:00
parent 556c7bb7df
commit f66e5b2907
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/pci/host/pcie-iproc-bcma.c
View file

@ -55,6 +55,11 @@ static int iproc_pcie_bcma_probe(struct bcma_device *bdev)
pcie->dev = dev; pcie->dev = dev;
pcie->base = bdev->io_addr; pcie->base = bdev->io_addr;
if (!pcie->base) {
dev_err(dev, "no controller registers\n");
return -ENOMEM;
}
pcie->base_addr = bdev->addr; pcie->base_addr = bdev->addr;
res_mem.start = bdev->addr_s[0]; res_mem.start = bdev->addr_s[0];

2
drivers/pci/host/pcie-iproc.c
View file

@ -462,7 +462,7 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res)
void *sysdata; void *sysdata;
struct pci_bus *bus; struct pci_bus *bus;
if (!pcie || !pcie->dev || !pcie->base) if (!pcie || !pcie->dev)
return -EINVAL; return -EINVAL;
dev = pcie->dev; dev = pcie->dev;