Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mfd: twl4030: Don't warn about uninitialized return code

Browse source 
If the twl4030_write_script function gets called with
a zero length argument, its return value does not
get set. We know that all scripts have a nonzero
length, but returning an error in case they ever
do is probably appropriate.

Without this patch, building omap2plus_defconfig results in:

drivers/mfd/twl4030-power.c: In function 'load_twl4030_script':
drivers/mfd/twl4030-power.c:414:5: error: 'err' may be used uninitialized in this function

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: "Kristo, Tero" <t-kristo@ti.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Arnd Bergmann 2013-01-25 14:14:26 +00:00 committed by Samuel Ortiz
parent 0a8c290ac5
commit f65e9eacfa
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/mfd/twl4030-power.c
View file

@ -159,7 +159,7 @@ static int twl4030_write_script_ins(u8 address, u16 pmb_message,
static int twl4030_write_script(u8 address, struct twl4030_ins *script,
int len)
{
int err;
int err = -EINVAL;
for (; len; len--, address++, script++) {
if (len == 1) {