Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tools: cpupower: fix wrong err msg not supported vs not available

Browse source 
idlestates in sysfs are counted from 0.

This fixes a wrong error message.
Current behavior on a machine with 4 sleep states is:

cpupower idle-set -e 4
Idlestate 4 enabled on CPU 0

-----Wrong---------------------
cpupower idle-set -e 5
Idlestate enabling not supported by kernel
-----Must and now will be -----
cpupower idle-set -e 5
Idlestate 6 not available on CPU 0
-------------------------------

cpupower idle-set -e 6
Idlestate 6 not available on CPU 0

Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Thomas Renninger 2013-11-16 14:39:22 +01:00 • committed by Rafael J. Wysocki
parent 5094d27171
commit f4a5d17efe
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/power/cpupower/utils/helpers/sysfs.c
View file

@ -278,7 +278,7 @@ static char *sysfs_idlestate_get_one_string(unsigned int cpu,
int sysfs_is_idlestate_disabled(unsigned int cpu, int sysfs_is_idlestate_disabled(unsigned int cpu,
unsigned int idlestate) unsigned int idlestate)
{ {
if (sysfs_get_idlestate_count(cpu) < idlestate) if (sysfs_get_idlestate_count(cpu) <= idlestate)
return -1; return -1;
if (!sysfs_idlestate_file_exists(cpu, idlestate, if (!sysfs_idlestate_file_exists(cpu, idlestate,
@ -303,7 +303,7 @@ int sysfs_idlestate_disable(unsigned int cpu,
char value[SYSFS_PATH_MAX]; char value[SYSFS_PATH_MAX];
int bytes_written; int bytes_written;
if (sysfs_get_idlestate_count(cpu) < idlestate) if (sysfs_get_idlestate_count(cpu) <= idlestate)
return -1; return -1;
if (!sysfs_idlestate_file_exists(cpu, idlestate, if (!sysfs_idlestate_file_exists(cpu, idlestate,