Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

powerpc/cell/oprofile: Avoid double vfree of profile buffer

Browse source 
If an error occurs on opcontrol start, the event and per cpu buffers
are released.  If later opcontrol shutdown is called then the free
function will be called again to free buffers that no longer
exist.  This results in a kernel oops.  The following changes
prevent the call to delete buffers that don't exist.

Signed-off-by: Carl Love <carll@us.ibm.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Richter <robert.richter@amd.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Carl Love 2008-08-11 17:25:43 +10:00 committed by Paul Mackerras
parent 2bb2e1db90
commit f4156d1cd1
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/oprofile/cpu_buffer.c
View file

@ -38,8 +38,10 @@ void free_cpu_buffers(void)
{
int i;
for_each_online_cpu(i)
for_each_online_cpu(i) {
vfree(per_cpu(cpu_buffer, i).buffer);
per_cpu(cpu_buffer, i).buffer = NULL;
}
}
int alloc_cpu_buffers(void)

2
drivers/oprofile/event_buffer.c
View file

@ -93,6 +93,8 @@ int alloc_event_buffer(void)
void free_event_buffer(void)
{
vfree(event_buffer);
event_buffer = NULL;
}