mfd: twl6040: Fix error return code
Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
parent
6052d83e71
commit
f2b8678161
1 changed files with 1 additions and 0 deletions
|
@ -679,6 +679,7 @@ static int twl6040_probe(struct i2c_client *client,
|
|||
if (twl6040->rev < 0) {
|
||||
dev_err(&client->dev, "Failed to read revision register: %d\n",
|
||||
twl6040->rev);
|
||||
ret = twl6040->rev;
|
||||
goto gpio_err;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue