Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Staging: hv: vmbus: Correct some dated comments in channel.c

Browse source 
Correct some dated comments in channel.c.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
K. Y. Srinivasan 2011-06-06 15:49:56 -07:00 committed by Greg Kroah-Hartman
parent bed9ba7654
commit f27df643d0
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/staging/hv/channel.c
View file

@ -185,12 +185,12 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
openMsg = (struct vmbus_channel_open_channel *)openInfo->msg; openMsg = (struct vmbus_channel_open_channel *)openInfo->msg;
openMsg->header.msgtype = CHANNELMSG_OPENCHANNEL; openMsg->header.msgtype = CHANNELMSG_OPENCHANNEL;
openMsg->openid = newchannel->offermsg.child_relid; /* FIXME */ openMsg->openid = newchannel->offermsg.child_relid;
openMsg->child_relid = newchannel->offermsg.child_relid; openMsg->child_relid = newchannel->offermsg.child_relid;
openMsg->ringbuffer_gpadlhandle = newchannel->ringbuffer_gpadlhandle; openMsg->ringbuffer_gpadlhandle = newchannel->ringbuffer_gpadlhandle;
openMsg->downstream_ringbuffer_pageoffset = send_ringbuffer_size >> openMsg->downstream_ringbuffer_pageoffset = send_ringbuffer_size >>
PAGE_SHIFT; PAGE_SHIFT;
openMsg->server_contextarea_gpadlhandle = 0; /* TODO */ openMsg->server_contextarea_gpadlhandle = 0;
if (userdatalen > MAX_USER_DEFINED_BYTES) { if (userdatalen > MAX_USER_DEFINED_BYTES) {
err = -EINVAL; err = -EINVAL;
@ -364,11 +364,11 @@ static int create_gpadl_header(void *kbuffer, u32 size,
(struct vmbus_channel_gpadl_body *)msgbody->msg; (struct vmbus_channel_gpadl_body *)msgbody->msg;
/* /*
* FIXME:
* Gpadl is u32 and we are using a pointer which could * Gpadl is u32 and we are using a pointer which could
* be 64-bit * be 64-bit
* This is governed by the guest/host protocol and
* so the hypervisor gurantees that this is ok.
*/ */
/* gpadl_body->Gpadl = kbuffer; */
for (i = 0; i < pfncurr; i++) for (i = 0; i < pfncurr; i++)
gpadl_body->pfn[i] = pfn + pfnsum + i; gpadl_body->pfn[i] = pfn + pfnsum + i;
@ -462,7 +462,6 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer,
if (msgcount > 1) { if (msgcount > 1) {
list_for_each(curr, &msginfo->submsglist) { list_for_each(curr, &msginfo->submsglist) {
/* FIXME: should this use list_entry() instead ? */
submsginfo = (struct vmbus_channel_msginfo *)curr; submsginfo = (struct vmbus_channel_msginfo *)curr;
gpadl_body = gpadl_body =
(struct vmbus_channel_gpadl_body *)submsginfo->msg; (struct vmbus_channel_gpadl_body *)submsginfo->msg;
@ -577,8 +576,6 @@ void vmbus_close(struct vmbus_channel *channel)
vmbus_teardown_gpadl(channel, vmbus_teardown_gpadl(channel,
channel->ringbuffer_gpadlhandle); channel->ringbuffer_gpadlhandle);
/* TODO: Send a msg to release the childRelId */
/* Cleanup the ring buffers for this channel */ /* Cleanup the ring buffers for this channel */
hv_ringbuffer_cleanup(&channel->outbound); hv_ringbuffer_cleanup(&channel->outbound);
hv_ringbuffer_cleanup(&channel->inbound); hv_ringbuffer_cleanup(&channel->inbound);