Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

serial: pxa: Do not tweak clock in pxa serial write() function

Browse source 
The write() function could be used by printk(), which is atomic and
tweaking clock there can cause "BUG: sleeping function called from
invalid context".

Signed-off-by: Bao Haojun <hjbao@marvell.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Haojun Bao 2013-01-17 00:01:51 -08:00 committed by Greg Kroah-Hartman
parent b786337d8c
commit ed35e09248
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/tty/serial/pxa.c
View file

@ -672,7 +672,6 @@ serial_pxa_console_write(struct console *co, const char *s, unsigned int count)
unsigned long flags; unsigned long flags;
int locked = 1; int locked = 1;
clk_prepare_enable(up->clk);
local_irq_save(flags); local_irq_save(flags);
if (up->port.sysrq) if (up->port.sysrq)
@ -701,7 +700,6 @@ serial_pxa_console_write(struct console *co, const char *s, unsigned int count)
spin_unlock(&up->port.lock); spin_unlock(&up->port.lock);
local_irq_restore(flags); local_irq_restore(flags);
clk_disable_unprepare(up->clk);
} }
#ifdef CONFIG_CONSOLE_POLL #ifdef CONFIG_CONSOLE_POLL