Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

dmaengine: xgene: buffer overflow in xgene_dma_init_channels()

Browse source 
We put 9 characters into the 8 character name[] array.  Let's make the
array bigger and change the sprintf() to snprintf().

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
Dan Carpenter 2015-04-09 12:05:04 +03:00 committed by Vinod Koul
parent d7d8e892aa
commit ed1f041842
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/dma/xgene-dma.c
View file

@ -314,7 +314,7 @@ struct xgene_dma_chan {
struct device *dev; struct device *dev;
int id; int id;
int rx_irq; int rx_irq;
char name[8]; char name[10];
spinlock_t lock; spinlock_t lock;
int pending; int pending;
int max_outstanding; int max_outstanding;
@ -1876,7 +1876,7 @@ static void xgene_dma_init_channels(struct xgene_dma *pdma)
chan->dev = pdma->dev; chan->dev = pdma->dev;
chan->pdma = pdma; chan->pdma = pdma;
chan->id = i; chan->id = i;
sprintf(chan->name, "dmachan%d", chan->id); snprintf(chan->name, sizeof(chan->name), "dmachan%d", chan->id);
} }
} }