ipv6: use skb coalescing in reassembly
ip6_frag_reasm() can use skb_try_coalesce() to build optimized skb, reducing memory used by them (truesize), and reducing number of cache line misses and overhead for the consumer. Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
3cc4949269
commit
ec16439e17
1 changed files with 20 additions and 6 deletions
|
@ -415,6 +415,7 @@ static int ip6_frag_reasm(struct frag_queue *fq, struct sk_buff *prev,
|
||||||
struct sk_buff *fp, *head = fq->q.fragments;
|
struct sk_buff *fp, *head = fq->q.fragments;
|
||||||
int payload_len;
|
int payload_len;
|
||||||
unsigned int nhoff;
|
unsigned int nhoff;
|
||||||
|
int sum_truesize;
|
||||||
|
|
||||||
fq_kill(fq);
|
fq_kill(fq);
|
||||||
|
|
||||||
|
@ -484,20 +485,33 @@ static int ip6_frag_reasm(struct frag_queue *fq, struct sk_buff *prev,
|
||||||
head->mac_header += sizeof(struct frag_hdr);
|
head->mac_header += sizeof(struct frag_hdr);
|
||||||
head->network_header += sizeof(struct frag_hdr);
|
head->network_header += sizeof(struct frag_hdr);
|
||||||
|
|
||||||
skb_shinfo(head)->frag_list = head->next;
|
|
||||||
skb_reset_transport_header(head);
|
skb_reset_transport_header(head);
|
||||||
skb_push(head, head->data - skb_network_header(head));
|
skb_push(head, head->data - skb_network_header(head));
|
||||||
|
|
||||||
for (fp=head->next; fp; fp = fp->next) {
|
sum_truesize = head->truesize;
|
||||||
head->data_len += fp->len;
|
for (fp = head->next; fp;) {
|
||||||
head->len += fp->len;
|
bool headstolen;
|
||||||
|
int delta;
|
||||||
|
struct sk_buff *next = fp->next;
|
||||||
|
|
||||||
|
sum_truesize += fp->truesize;
|
||||||
if (head->ip_summed != fp->ip_summed)
|
if (head->ip_summed != fp->ip_summed)
|
||||||
head->ip_summed = CHECKSUM_NONE;
|
head->ip_summed = CHECKSUM_NONE;
|
||||||
else if (head->ip_summed == CHECKSUM_COMPLETE)
|
else if (head->ip_summed == CHECKSUM_COMPLETE)
|
||||||
head->csum = csum_add(head->csum, fp->csum);
|
head->csum = csum_add(head->csum, fp->csum);
|
||||||
head->truesize += fp->truesize;
|
|
||||||
|
if (skb_try_coalesce(head, fp, &headstolen, &delta)) {
|
||||||
|
kfree_skb_partial(fp, headstolen);
|
||||||
|
} else {
|
||||||
|
if (!skb_shinfo(head)->frag_list)
|
||||||
|
skb_shinfo(head)->frag_list = fp;
|
||||||
|
head->data_len += fp->len;
|
||||||
|
head->len += fp->len;
|
||||||
|
head->truesize += fp->truesize;
|
||||||
|
}
|
||||||
|
fp = next;
|
||||||
}
|
}
|
||||||
atomic_sub(head->truesize, &fq->q.net->mem);
|
atomic_sub(sum_truesize, &fq->q.net->mem);
|
||||||
|
|
||||||
head->next = NULL;
|
head->next = NULL;
|
||||||
head->dev = dev;
|
head->dev = dev;
|
||||||
|
|
Loading…
Reference in a new issue