Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

atm: [lec] initialize .netdev_ops before calling register_netdev()

Browse source 
fix oops when initializing lane interfaces. lec should probably be
changed to use alloc_netdev() instead.

Signed-off-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
chas williams - CONTRACTOR 2009-12-04 05:19:30 +00:00 committed by David S. Miller
parent 2a8875e73f
commit eb0445887a
1 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
net/atm/lec.c
View file

@ -62,7 +62,6 @@ static int lec_open(struct net_device *dev);
static netdev_tx_t lec_start_xmit(struct sk_buff *skb, static netdev_tx_t lec_start_xmit(struct sk_buff *skb,
struct net_device *dev); struct net_device *dev);
static int lec_close(struct net_device *dev); static int lec_close(struct net_device *dev);
static void lec_init(struct net_device *dev);
static struct lec_arp_table *lec_arp_find(struct lec_priv *priv, static struct lec_arp_table *lec_arp_find(struct lec_priv *priv,
const unsigned char *mac_addr); const unsigned char *mac_addr);
static int lec_arp_remove(struct lec_priv *priv, static int lec_arp_remove(struct lec_priv *priv,
@ -670,13 +669,6 @@ static const struct net_device_ops lec_netdev_ops = {
.ndo_set_multicast_list = lec_set_multicast_list, .ndo_set_multicast_list = lec_set_multicast_list,
}; };
static void lec_init(struct net_device *dev)
{
dev->netdev_ops = &lec_netdev_ops;
printk("%s: Initialized!\n", dev->name);
}
static const unsigned char lec_ctrl_magic[] = { static const unsigned char lec_ctrl_magic[] = {
0xff, 0xff,
0x00, 0x00,
@ -893,6 +885,7 @@ static int lecd_attach(struct atm_vcc *vcc, int arg)
dev_lec[i] = alloc_etherdev(size); dev_lec[i] = alloc_etherdev(size);
if (!dev_lec[i]) if (!dev_lec[i])
return -ENOMEM; return -ENOMEM;
dev_lec[i]->netdev_ops = &lec_netdev_ops;
snprintf(dev_lec[i]->name, IFNAMSIZ, "lec%d", i); snprintf(dev_lec[i]->name, IFNAMSIZ, "lec%d", i);
if (register_netdev(dev_lec[i])) { if (register_netdev(dev_lec[i])) {
free_netdev(dev_lec[i]); free_netdev(dev_lec[i]);
@ -901,7 +894,6 @@ static int lecd_attach(struct atm_vcc *vcc, int arg)
priv = netdev_priv(dev_lec[i]); priv = netdev_priv(dev_lec[i]);
priv->is_trdev = is_trdev; priv->is_trdev = is_trdev;
lec_init(dev_lec[i]);
} else { } else {
priv = netdev_priv(dev_lec[i]); priv = netdev_priv(dev_lec[i]);
if (priv->lecd) if (priv->lecd)