Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

asoc: wcd9360-dsp-cntl: initialize local char array val

Browse source 
Due to the local char array that stores the codec dsp control command
is not initialized, an invalid command could cause the stack content
to be printed out in kernel dmesg. Initialize the array with memset.

Change-Id: I07211c4cc06b2c2df21b674e6812c4d5efc45dc4
Signed-off-by: Xiaoyu Ye <benyxy@codeaurora.org>
This commit is contained in:
Xiaoyu Ye 2018-07-31 12:03:27 -07:00
parent 2e628184b9
commit e45af077d8
1 changed files with 3 additions and 1 deletions

4
asoc/codecs/wcd9360/wcd9360-dsp-cntl.c
View file

@ -894,10 +894,12 @@ static ssize_t wcd_miscdev_write(struct file *filep, const char __user *ubuf,
{
struct wcd_dsp_cntl *cntl = container_of(filep->private_data,
struct wcd_dsp_cntl, miscdev);
char val[WCD_MISCDEV_CMD_MAX_LEN];
char val[WCD_MISCDEV_CMD_MAX_LEN + 1];
bool vote;
int ret = 0;
memset(val, 0, WCD_MISCDEV_CMD_MAX_LEN + 1);
if (count == 0 || count > WCD_MISCDEV_CMD_MAX_LEN) {
pr_err("%s: Invalid count = %zd\n", __func__, count);
ret = -EINVAL;