mm/mmap.c: optimization of do_mmap_pgoff function
The simple check for zero length memory mapping may be performed earlier. So that in case of zero length memory mapping some unnecessary code is not executed at all. It does not make the code less readable and saves some CPU cycles. Signed-off-by: Piotr Kwapulinski <kwapulinski.piotr@gmail.com> Acked-by: Michal Hocko <mhocko@suse.cz> Acked-by: Rik van Riel <riel@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
93ada579b0
commit
e37609bb36
1 changed files with 3 additions and 3 deletions
|
@ -1258,6 +1258,9 @@ unsigned long do_mmap_pgoff(struct file *file, unsigned long addr,
|
||||||
|
|
||||||
*populate = 0;
|
*populate = 0;
|
||||||
|
|
||||||
|
if (!len)
|
||||||
|
return -EINVAL;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Does the application expect PROT_READ to imply PROT_EXEC?
|
* Does the application expect PROT_READ to imply PROT_EXEC?
|
||||||
*
|
*
|
||||||
|
@ -1268,9 +1271,6 @@ unsigned long do_mmap_pgoff(struct file *file, unsigned long addr,
|
||||||
if (!(file && (file->f_path.mnt->mnt_flags & MNT_NOEXEC)))
|
if (!(file && (file->f_path.mnt->mnt_flags & MNT_NOEXEC)))
|
||||||
prot |= PROT_EXEC;
|
prot |= PROT_EXEC;
|
||||||
|
|
||||||
if (!len)
|
|
||||||
return -EINVAL;
|
|
||||||
|
|
||||||
if (!(flags & MAP_FIXED))
|
if (!(flags & MAP_FIXED))
|
||||||
addr = round_hint_to_min(addr);
|
addr = round_hint_to_min(addr);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue