Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

iio: accel: mma9551: Check gpiod_to_irq return value

Browse source 
The return value of gpiod_to_irq should be checked before giving
it to devm_request_threaded_irq in order to not pass an error
code in case it fails.

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Reviewed-by: Vlad Dogaru <vlad.dogaru@intel.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
Roberta Dobrescu 2015-03-02 12:39:12 +02:00 committed by Jonathan Cameron
parent 4a428bf3d9
commit debf6d843e
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/iio/accel/mma9551.c
View file

@ -425,7 +425,11 @@ static int mma9551_gpio_probe(struct iio_dev *indio_dev)
return PTR_ERR(gpio); return PTR_ERR(gpio);
} }
data->irqs[i] = gpiod_to_irq(gpio); ret = gpiod_to_irq(gpio);
if (ret < 0)
return ret;
data->irqs[i] = ret;
ret = devm_request_threaded_irq(dev, data->irqs[i], ret = devm_request_threaded_irq(dev, data->irqs[i],
NULL, mma9551_event_handler, NULL, mma9551_event_handler,
IRQF_TRIGGER_RISING | IRQF_ONESHOT, IRQF_TRIGGER_RISING | IRQF_ONESHOT,