Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

GFS2: write_end error path fails to unlock transaction lock

Browse source 
I did an audit of gfs2's transaction glock for bugzilla bug
658619 and ran across this:

In function gfs2_write_end, in the unlikely event that
gfs2_meta_inode_buffer returns an error, the code may forget
to unlock the transaction lock because the "failed" label
appears after the call to function gfs2_trans_end.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
This commit is contained in:
Bob Peterson 2011-03-16 16:32:39 -04:00 • committed by Steven Whitehouse
parent a1b49cb7e2
commit deab72d379
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
fs/gfs2/aops.c
View file

@ -884,8 +884,8 @@ static int gfs2_write_end(struct file *file, struct address_space *mapping,
} }
brelse(dibh); brelse(dibh);
gfs2_trans_end(sdp);
failed: failed:
gfs2_trans_end(sdp);
if (al) { if (al) {
gfs2_inplace_release(ip); gfs2_inplace_release(ip);
gfs2_quota_unlock(ip); gfs2_quota_unlock(ip);