Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mISDN: get_free_devid() failure ignored

Browse source 
dev->id is unsigned so a get_free_devid() error is ignored.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Karsten Keil <keil@b1-systems.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Roel Kluin 2009-05-22 11:04:53 +00:00 • committed by David S. Miller
parent db9bb63a1b
commit ddacd14e8d
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/isdn/mISDN/core.c
View file

@ -214,7 +214,7 @@ get_free_devid(void)
if (!test_and_set_bit(i, (u_long *)&device_ids)) if (!test_and_set_bit(i, (u_long *)&device_ids))
break; break;
if (i > MAX_DEVICE_ID) if (i > MAX_DEVICE_ID)
return -1; return -EBUSY;
return i; return i;
} }
@ -224,10 +224,10 @@ mISDN_register_device(struct mISDNdevice *dev,
{ {
int err; int err;
dev->id = get_free_devid(); err = get_free_devid();
err = -EBUSY; if (err < 0)
if (dev->id < 0)
goto error1; goto error1;
dev->id = err;
device_initialize(&dev->dev); device_initialize(&dev->dev);
if (name && name[0]) if (name && name[0])