Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ext4: Remove unneeded BUG_ON() in ext4_move_extents()

Browse source 
The ext4_move_extents() functions checks with BUG_ON() whether the
exchanged blocks count accords with request blocks count.  But, if the
target range (orig_start + len) includes sparse block(s), 'moved_len'
(exchanged blocks count) does not agree with 'len' (request blocks
count), since sparse block is not counted in 'moved_len'.  This causes
us to hit the BUG_ON(), even though the function succeeded.

Signed-off-by: Akira Fujita <a-fujita@rs.jp.nec.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
This commit is contained in:
Akira Fujita 2009-09-05 22:11:55 -04:00 committed by Theodore Ts'o
parent 70d5d3dcea
commit daea696dba
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
fs/ext4/move_extent.c
View file

@ -1322,8 +1322,5 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp,
if (ret)
return ret;
/* All of the specified blocks must be exchanged in succeed */
BUG_ON(*moved_len != len);
return 0;
}