Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ASoC: hisilicon: Add error returns even for cases that shouldn't happen.

Browse source 
This patch addresses feedback from Mark Brown, adding a few
extra error returns in cases that shouldn't happen

Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
John Stultz 2017-04-11 12:15:16 -07:00 committed by Mark Brown
parent 86666c083a
commit da13d7462b
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sound/soc/hisilicon/hi6210-i2s.c
View file

@ -395,6 +395,7 @@ static int hi6210_i2s_hw_params(struct snd_pcm_substream *substream,
break; break;
default: default:
WARN_ONCE(1, "Invalid i2s->fmt MASTER_MASK. This shouldn't happen\n"); WARN_ONCE(1, "Invalid i2s->fmt MASTER_MASK. This shouldn't happen\n");
return -EINVAL;
} }
switch (i2s->format & SND_SOC_DAIFMT_FORMAT_MASK) { switch (i2s->format & SND_SOC_DAIFMT_FORMAT_MASK) {
@ -409,6 +410,7 @@ static int hi6210_i2s_hw_params(struct snd_pcm_substream *substream,
break; break;
default: default:
WARN_ONCE(1, "Invalid i2s->fmt FORMAT_MASK. This shouldn't happen\n"); WARN_ONCE(1, "Invalid i2s->fmt FORMAT_MASK. This shouldn't happen\n");
return -EINVAL;
} }
val = hi6210_read_reg(i2s, HII2S_I2S_CFG); val = hi6210_read_reg(i2s, HII2S_I2S_CFG);