cifs: fix memory leak when password is supplied multiple times
Unlikely but possible. When password is supplied multiple times, we have to free the previous allocation. Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com> Signed-off-by: Steve French <smfrench@gmail.com>
This commit is contained in:
parent
27b7edcf1c
commit
d6ccf4997e
1 changed files with 2 additions and 0 deletions
|
@ -1600,6 +1600,7 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
|
|||
tmp_end++;
|
||||
if (!(tmp_end < end && tmp_end[1] == delim)) {
|
||||
/* No it is not. Set the password to NULL */
|
||||
kfree(vol->password);
|
||||
vol->password = NULL;
|
||||
break;
|
||||
}
|
||||
|
@ -1637,6 +1638,7 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
|
|||
options = end;
|
||||
}
|
||||
|
||||
kfree(vol->password);
|
||||
/* Now build new password string */
|
||||
temp_len = strlen(value);
|
||||
vol->password = kzalloc(temp_len+1, GFP_KERNEL);
|
||||
|
|
Loading…
Reference in a new issue