Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] taskstats: fix sk_buff leak

Browse source 
'return genlmsg_cancel()' in taskstats_user_cmd/taskstats_exit_send
potentially leaks a skb.  Unless we pass 'rep_skb' to the netlink layer
we own sk_buff.  This means we should always do kfree_skb() on failure.

[ Thomas acked and pointed out missing return value in original version ]

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Thomas Graf <tgraf@suug.ch>
Cc: Andrew Morton <akpm@osdl.org>
Cc: Shailabh Nagar <nagar@watson.ibm.com>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Jay Lan <jlan@sgi.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Oleg Nesterov 2006-10-29 16:45:58 +03:00 committed by Linus Torvalds
parent 5211e6e6c6
commit d46a3d0d07
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
kernel/taskstats.c
View file

@ -411,7 +411,7 @@ static int taskstats_user_cmd(struct sk_buff *skb, struct genl_info *info)
return send_reply(rep_skb, info->snd_pid); return send_reply(rep_skb, info->snd_pid);
nla_put_failure: nla_put_failure:
return genlmsg_cancel(rep_skb, reply); rc = genlmsg_cancel(rep_skb, reply);
err: err:
nlmsg_free(rep_skb); nlmsg_free(rep_skb);
return rc; return rc;
@ -507,7 +507,6 @@ void taskstats_exit_send(struct task_struct *tsk, struct taskstats *tidstats,
nla_put_failure: nla_put_failure:
genlmsg_cancel(rep_skb, reply); genlmsg_cancel(rep_skb, reply);
goto ret;
err_skb: err_skb:
nlmsg_free(rep_skb); nlmsg_free(rep_skb);
ret: ret: