Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

spi/sh-hspi: fix return value check in hspi_probe().

Browse source 
According to its documentation, clk_get() returns a "valid IS_ERR() condition
containing errno", so we should call IS_ERR() rather than a NULL check.

Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
This commit is contained in:
Cyril Roelandt 2012-12-12 01:24:54 +01:00 committed by Grant Likely
parent 6a79131318
commit d3601e56cf
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/spi/spi-sh-hspi.c
View file

@ -290,7 +290,7 @@ static int hspi_probe(struct platform_device *pdev)
} }
clk = clk_get(NULL, "shyway_clk"); clk = clk_get(NULL, "shyway_clk");
if (!clk) { if (IS_ERR(clk)) {
dev_err(&pdev->dev, "shyway_clk is required\n"); dev_err(&pdev->dev, "shyway_clk is required\n");
ret = -EINVAL; ret = -EINVAL;
goto error0; goto error0;