Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[MTD] [NAND] Fix an off-by-one in a BUG_ON in CAFÉ ECC correction.

Browse source 
err_pos_lut[4096] of an array with 4096 elements is a bug.

Spotted by the Coverity checker.

While I was at it, I also converted it to ARRAY_SIZE().

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
This commit is contained in:
Adrian Bunk 2007-02-02 15:29:19 +01:00 committed by David Woodhouse
parent 0373615579
commit d24030f0f7
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/mtd/nand/cafe_ecc.c
View file

@ -1045,7 +1045,7 @@ static unsigned short err_pos_lut[4096] = {
static unsigned short err_pos(unsigned short din) static unsigned short err_pos(unsigned short din)
{ {
BUG_ON(din > 4096); BUG_ON(din >= ARRAY_SIZE(err_pos_lut));
return err_pos_lut[din]; return err_pos_lut[din];
} }
static int chk_no_err_only(unsigned short *chk_syndrome_list, unsigned short *err_info) static int chk_no_err_only(unsigned short *chk_syndrome_list, unsigned short *err_info)