Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

pinctrl: sunxi: make sun5i explicitly non-modular

Browse source 
We had all these corrected in commit 0c8c6ba00c ("pinctrl: sunxi:
make bool drivers explicitly non-modular") but this new one recently
crept in.

The Kconfig currently controlling compilation of this code is:

   drivers/pinctrl/sunxi/Kconfig:config PINCTRL_SUN5I
   drivers/pinctrl/sunxi/Kconfig:  def_bool MACH_SUN5I

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modular infrastructure use, so that
when reading the driver there is no doubt it is builtin-only.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Paul Gortmaker 2017-02-02 15:17:40 -05:00 committed by Linus Walleij
parent 1fe57d67e0
commit cff1f7a9a2
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/pinctrl/sunxi/pinctrl-sun5i.c
View file

@ -4,12 +4,12 @@
* Copyright (C) 2014-2016 Maxime Ripard <maxime.ripard@free-electrons.com>
* Copyright (C) 2016 Mylene Josserand <mylene.josserand@free-electrons.com>
*
g * This file is licensed under the terms of the GNU General Public
* This file is licensed under the terms of the GNU General Public
* License version 2. This program is licensed "as is" without any
* warranty of any kind, whether express or implied.
*/
#include <linux/module.h>
#include <linux/init.h>
#include <linux/platform_device.h>
#include <linux/of.h>
#include <linux/of_device.h>
@ -738,7 +738,6 @@ static const struct of_device_id sun5i_pinctrl_match[] = {
},
{ },
};
MODULE_DEVICE_TABLE(of, sun5i_pinctrl_match);
static struct platform_driver sun5i_pinctrl_driver = {
.probe = sun5i_pinctrl_probe,
@ -747,8 +746,4 @@ static struct platform_driver sun5i_pinctrl_driver = {
.of_match_table = sun5i_pinctrl_match,
},
};
module_platform_driver(sun5i_pinctrl_driver);
MODULE_AUTHOR("Maxime Ripard <maxime.ripard@free-electrons.com");
MODULE_DESCRIPTION("Allwinner sun5i pinctrl driver");
MODULE_LICENSE("GPL");
builtin_platform_driver(sun5i_pinctrl_driver);