Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

net/rxrpc/ar-peer.c: remove invalid reference to list iterator variable

Browse source 
If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  This seems to be a copy-paste bug from a previous
debugging message, and so the meaningless value is just deleted.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Julia Lawall 2012-07-08 01:37:39 +00:00 committed by David S. Miller
parent 1b9faf5e66
commit cae296c42c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/rxrpc/ar-peer.c
View file

@ -229,7 +229,7 @@ struct rxrpc_peer *rxrpc_find_peer(struct rxrpc_local *local,
return peer; return peer;
new_UDP_peer: new_UDP_peer:
_net("Rx UDP DGRAM from NEW peer %d", peer->debug_id); _net("Rx UDP DGRAM from NEW peer");
read_unlock_bh(&rxrpc_peer_lock); read_unlock_bh(&rxrpc_peer_lock);
_leave(" = -EBUSY [new]"); _leave(" = -EBUSY [new]");
return ERR_PTR(-EBUSY); return ERR_PTR(-EBUSY);