Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] macintosh: don't store i2c_add_driver() return if no further processing done

Browse source 
therm_pm72.c and windfarm_lm75_sensor.c both store the return from
i2c_add_driver() but do no further processing on the result.  Simply return
what i2c_add_driver() did, instead.

Signed-off-by: Arthur Othieno <a.othieno@bluewin.ch>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Arthur Othieno 2006-01-06 00:11:29 -08:00 committed by Linus Torvalds
parent e13ac21981
commit c9662b4b37
2 changed files with 2 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/macintosh/therm_pm72.c
View file

@ -1988,18 +1988,13 @@ static void fcu_lookup_fans(struct device_node *fcu_node)
static int fcu_of_probe(struct of_device* dev, const struct of_device_id *match) static int fcu_of_probe(struct of_device* dev, const struct of_device_id *match)
{ {
int rc;
state = state_detached; state = state_detached;
/* Lookup the fans in the device tree */ /* Lookup the fans in the device tree */
fcu_lookup_fans(dev->node); fcu_lookup_fans(dev->node);
/* Add the driver */ /* Add the driver */
rc = i2c_add_driver(&therm_pm72_driver); return i2c_add_driver(&therm_pm72_driver);
if (rc < 0)
return rc;
return 0;
} }
static int fcu_of_remove(struct of_device* dev) static int fcu_of_remove(struct of_device* dev)

7
drivers/macintosh/windfarm_lm75_sensor.c
View file

@ -240,12 +240,7 @@ static int wf_lm75_detach(struct i2c_client *client)
static int __init wf_lm75_sensor_init(void) static int __init wf_lm75_sensor_init(void)
{ {
int rc; return i2c_add_driver(&wf_lm75_driver);
rc = i2c_add_driver(&wf_lm75_driver);
if (rc < 0)
return rc;
return 0;
} }
static void __exit wf_lm75_sensor_exit(void) static void __exit wf_lm75_sensor_exit(void)