Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[NET]: Disallow whitespace in network device names.

Browse source 
It causes way too much trouble and confusion in userspace.

Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David S. Miller 2006-08-15 16:34:13 -07:00
parent d4274b51a5
commit c7fa9d189e
1 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
net/core/dev.c
View file

@ -116,6 +116,7 @@
#include <linux/audit.h> #include <linux/audit.h>
#include <linux/dmaengine.h> #include <linux/dmaengine.h>
#include <linux/err.h> #include <linux/err.h>
#include <linux/ctype.h>
/* /*
* The list of packet types we will receive (as opposed to discard) * The list of packet types we will receive (as opposed to discard)
@ -632,14 +633,22 @@ struct net_device * dev_get_by_flags(unsigned short if_flags, unsigned short mas
* @name: name string * @name: name string
* *
* Network device names need to be valid file names to * Network device names need to be valid file names to
* to allow sysfs to work * to allow sysfs to work. We also disallow any kind of
* whitespace.
*/ */
int dev_valid_name(const char *name) int dev_valid_name(const char *name)
{ {
return !(*name == '\0' if (*name == '\0')
|| !strcmp(name, ".") return 0;
|| !strcmp(name, "..") if (!strcmp(name, ".") || !strcmp(name, ".."))
|| strchr(name, '/')); return 0;
while (*name) {
if (*name == '/' || isspace(*name))
return 0;
name++;
}
return 1;
} }
/** /**