Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] sysfs: if show/store is missing return -EIO

Browse source 
sysfs: if attribute does not implement show or store method
       read/write should return -EIO instead of 0 or -EINVAL.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Dmitry Torokhov 2005-04-29 01:22:00 -05:00 committed by Greg Kroah-Hartman
parent d48593bf20
commit c76d0abd07
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
fs/sysfs/bin.c
View file

@ -25,7 +25,7 @@ fill_read(struct dentry *dentry, char *buffer, loff_t off, size_t count)
struct kobject * kobj = to_kobj(dentry->d_parent); struct kobject * kobj = to_kobj(dentry->d_parent);
if (!attr->read) if (!attr->read)
return -EINVAL; return -EIO;
return attr->read(kobj, buffer, off, count); return attr->read(kobj, buffer, off, count);
} }
@ -71,7 +71,7 @@ flush_write(struct dentry *dentry, char *buffer, loff_t offset, size_t count)
struct kobject *kobj = to_kobj(dentry->d_parent); struct kobject *kobj = to_kobj(dentry->d_parent);
if (!attr->write) if (!attr->write)
return -EINVAL; return -EIO;
return attr->write(kobj, buffer, offset, count); return attr->write(kobj, buffer, offset, count);
} }

4
fs/sysfs/file.c
View file

@ -23,7 +23,7 @@ subsys_attr_show(struct kobject * kobj, struct attribute * attr, char * page)
{ {
struct subsystem * s = to_subsys(kobj); struct subsystem * s = to_subsys(kobj);
struct subsys_attribute * sattr = to_sattr(attr); struct subsys_attribute * sattr = to_sattr(attr);
ssize_t ret = 0; ssize_t ret = -EIO;
if (sattr->show) if (sattr->show)
ret = sattr->show(s,page); ret = sattr->show(s,page);
@ -36,7 +36,7 @@ subsys_attr_store(struct kobject * kobj, struct attribute * attr,
{ {
struct subsystem * s = to_subsys(kobj); struct subsystem * s = to_subsys(kobj);
struct subsys_attribute * sattr = to_sattr(attr); struct subsys_attribute * sattr = to_sattr(attr);
ssize_t ret = 0; ssize_t ret = -EIO;
if (sattr->store) if (sattr->store)
ret = sattr->store(s,page,count); ret = sattr->store(s,page,count);