Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

regulator: twl6030: remove redundant range check min_uV > 1300000 && min_uV <= 1350000

Browse source 
It has been pointed out to me that the range for vsel = 58 is actually
dead code as this is covered by an earlier check for (min_uV >= 700000)
&& (min_uV <= 1420000) so remove that check completely.

Reported-by: Alban Auzeill <alban.auzeill@sonarsource.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Colin Ian King 2017-03-24 17:13:50 +00:00 committed by Mark Brown
parent d00b74613f
commit c635df496a
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/regulator/twl6030-regulator.c
View file

@ -456,8 +456,6 @@ static int twl6030smps_map_voltage(struct regulator_dev *rdev, int min_uV,
vsel = 60; vsel = 60;
else if ((min_uV > 1350000) && (min_uV <= 1500000)) else if ((min_uV > 1350000) && (min_uV <= 1500000))
vsel = 59; vsel = 59;
else if ((min_uV > 1300000) && (min_uV <= 1350000))
vsel = 58;
else else
return -EINVAL; return -EINVAL;
break; break;