Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[ALSA] Routines for effect processor FX8010: Use list_for_each_entry

Browse source 
Routines for effect processor FX8010: Use list_for_each_entry instead
of list_for_each

Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
This commit is contained in:
Matthias Kaehlcke 2007-09-17 14:41:16 +02:00 committed by Jaroslav Kysela
parent 33206e862e
commit c2d7051ed1
2 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/sound/emu10k1.h
View file

@ -1408,8 +1408,6 @@ struct snd_emu10k1_fx8010 {
struct snd_emu10k1_fx8010_irq *irq_handlers; struct snd_emu10k1_fx8010_irq *irq_handlers;
}; };
#define emu10k1_gpr_ctl(n) list_entry(n, struct snd_emu10k1_fx8010_ctl, list)
struct snd_emu10k1_midi { struct snd_emu10k1_midi {
struct snd_emu10k1 *emu; struct snd_emu10k1 *emu;
struct snd_rawmidi *rmidi; struct snd_rawmidi *rmidi;

10
sound/pci/emu10k1/emufx.c
View file

@ -642,10 +642,8 @@ snd_emu10k1_look_for_ctl(struct snd_emu10k1 *emu, struct snd_ctl_elem_id *id)
{ {
struct snd_emu10k1_fx8010_ctl *ctl; struct snd_emu10k1_fx8010_ctl *ctl;
struct snd_kcontrol *kcontrol; struct snd_kcontrol *kcontrol;
struct list_head *list;
list_for_each_entry(ctl, &emu->fx8010.gpr_ctl, list) {
list_for_each(list, &emu->fx8010.gpr_ctl) {
ctl = emu10k1_gpr_ctl(list);
kcontrol = ctl->kcontrol; kcontrol = ctl->kcontrol;
if (kcontrol->id.iface == id->iface && if (kcontrol->id.iface == id->iface &&
!strcmp(kcontrol->id.name, id->name) && !strcmp(kcontrol->id.name, id->name) &&
@ -895,14 +893,12 @@ static int snd_emu10k1_list_controls(struct snd_emu10k1 *emu,
struct snd_emu10k1_fx8010_control_gpr *gctl; struct snd_emu10k1_fx8010_control_gpr *gctl;
struct snd_emu10k1_fx8010_ctl *ctl; struct snd_emu10k1_fx8010_ctl *ctl;
struct snd_ctl_elem_id *id; struct snd_ctl_elem_id *id;
struct list_head *list;
gctl = kmalloc(sizeof(*gctl), GFP_KERNEL); gctl = kmalloc(sizeof(*gctl), GFP_KERNEL);
if (! gctl) if (! gctl)
return -ENOMEM; return -ENOMEM;
list_for_each(list, &emu->fx8010.gpr_ctl) { list_for_each_entry(ctl, &emu->fx8010.gpr_ctl, list) {
ctl = emu10k1_gpr_ctl(list);
total++; total++;
if (icode->gpr_list_controls && if (icode->gpr_list_controls &&
i < icode->gpr_list_control_count) { i < icode->gpr_list_control_count) {