Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fs: Use BUG_ON(!mnt) at dentry_open().

Browse source 
dentry_open() requires callers to pass a valid vfsmount.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Tetsuo Handa 2011-01-19 21:08:41 +09:00 • committed by Al Viro
parent aa597bc1f9
commit c212f9aaf9
1 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
fs/open.c
View file

@ -835,17 +835,8 @@ struct file *dentry_open(struct dentry *dentry, struct vfsmount *mnt, int flags,
validate_creds(cred); validate_creds(cred);
/* /* We must always pass in a valid mount pointer. */
* We must always pass in a valid mount pointer. Historically BUG_ON(!mnt);
* callers got away with not passing it, but we must enforce this at
* the earliest possible point now to avoid strange problems deep in the
* filesystem stack.
*/
if (!mnt) {
printk(KERN_WARNING "%s called with NULL vfsmount\n", __func__);
dump_stack();
return ERR_PTR(-EINVAL);
}
error = -ENFILE; error = -ENFILE;
f = get_empty_filp(); f = get_empty_filp();