Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

hwmon: (w83795) Avoid reading the same register twice

Browse source 
Shorten driver load time by avoiding duplicate register access during
initialization. This saves 112 ms on modprobe on my test system.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
This commit is contained in:
Jean Delvare 2010-10-28 20:31:47 +02:00 • committed by Jean Delvare
parent 02728ffef9
commit c1a792a6ee
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/hwmon/w83795.c
View file

@ -1986,6 +1986,9 @@ static int w83795_probe(struct i2c_client *client,
data->in[i][IN_READ] = tmp; data->in[i][IN_READ] = tmp;
} }
for (i = 0; i < IN_LSB_REG_NUM; i++) { for (i = 0; i < IN_LSB_REG_NUM; i++) {
if ((i == 2 && data->chip_type == w83795adg) ||
(i >= 4 && !(data->has_in & (1 << (i + 11)))))
continue;
data->in_lsb[i][IN_MAX] = data->in_lsb[i][IN_MAX] =
w83795_read(client, IN_LSB_REG(i, IN_MAX)); w83795_read(client, IN_LSB_REG(i, IN_MAX));
data->in_lsb[i][IN_LOW] = data->in_lsb[i][IN_LOW] =
@ -1995,13 +1998,17 @@ static int w83795_probe(struct i2c_client *client,
/* First update fan and limits */ /* First update fan and limits */
for (i = 0; i < ARRAY_SIZE(data->fan); i++) { for (i = 0; i < ARRAY_SIZE(data->fan); i++) {
/* Each register contains LSB for 2 fans, but we want to
* read it only once to save time */
if ((i & 1) == 0 && (data->has_fan & (3 << i)))
tmp = w83795_read(client, W83795_REG_FAN_MIN_LSB(i));
if (!(data->has_fan & (1 << i))) if (!(data->has_fan & (1 << i)))
continue; continue;
data->fan_min[i] = data->fan_min[i] =
w83795_read(client, W83795_REG_FAN_MIN_HL(i)) << 4; w83795_read(client, W83795_REG_FAN_MIN_HL(i)) << 4;
data->fan_min[i] |= data->fan_min[i] |=
(w83795_read(client, W83795_REG_FAN_MIN_LSB(i)) >> (tmp >> W83795_REG_FAN_MIN_LSB_SHIFT(i)) & 0x0F;
W83795_REG_FAN_MIN_LSB_SHIFT(i)) & 0x0F;
data->fan[i] = w83795_read(client, W83795_REG_FAN(i)) << 4; data->fan[i] = w83795_read(client, W83795_REG_FAN(i)) << 4;
data->fan[i] |= data->fan[i] |=
(w83795_read(client, W83795_REG_VRLSB) >> 4) & 0x0F; (w83795_read(client, W83795_REG_VRLSB) >> 4) & 0x0F;