Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] OSS: Fix leak in awe_wave, also remove pointless cast.

Browse source 
Fix resource leak and remove pointless cast of kmalloc return value.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Jesper Juhl 2006-03-25 03:08:11 -08:00 committed by Linus Torvalds
parent 96a9b4d31e
commit bda44e1d16
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sound/oss/awe_wave.c
View file

@ -2944,7 +2944,7 @@ alloc_new_info(void)
{
awe_voice_list *newlist;
newlist = (awe_voice_list *)kmalloc(sizeof(*newlist), GFP_KERNEL);
newlist = kmalloc(sizeof(*newlist), GFP_KERNEL);
if (newlist == NULL) {
printk(KERN_ERR "AWE32: can't alloc info table\n");
return NULL;
@ -3547,8 +3547,10 @@ awe_load_guspatch(const char __user *addr, int offs, int size, int pmgr_flag)
smp->checksum_flag = 0;
smp->checksum = 0;
if ((rc = awe_write_wave_data(addr, sizeof_patch, smprec, -1)) < 0)
if ((rc = awe_write_wave_data(addr, sizeof_patch, smprec, -1)) < 0) {
kfree(vrec);
return rc;
}
sf->mem_ptr += rc;
add_sf_sample(sf, smprec);