Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[media] drivers/media/pci/ttpci/budget-av.c: fix error return code

Browse source 
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Peter Senna Tschudin 2012-09-06 11:23:53 -03:00 committed by Mauro Carvalho Chehab
parent c4697d7f96
commit bc7c85e501
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/media/pci/ttpci/budget-av.c
View file

@ -1477,8 +1477,8 @@ static int budget_av_attach(struct saa7146_dev *dev, struct saa7146_pci_extensio
if (saa7113_init(budget_av) == 0) { if (saa7113_init(budget_av) == 0) {
budget_av->has_saa7113 = 1; budget_av->has_saa7113 = 1;
err = saa7146_vv_init(dev, &vv_data);
if (0 != saa7146_vv_init(dev, &vv_data)) { if (err != 0) {
/* fixme: proper cleanup here */ /* fixme: proper cleanup here */
ERR("cannot init vv subsystem\n"); ERR("cannot init vv subsystem\n");
return err; return err;