Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ext4: fix potential NULL dereference in ext4_free_inodes_counts()

Browse source 
The ext4_get_group_desc() function returns NULL on error, and
ext4_free_inodes_count() function dereferences it without checking.
There is a check on the next line, but it's too late.

Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
This commit is contained in:
Dan Carpenter 2012-05-28 14:16:57 -04:00 committed by Theodore Ts'o
parent e93376c20b
commit bb3d132a24
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
fs/ext4/ialloc.c
View file

@ -508,10 +508,12 @@ static int find_group_orlov(struct super_block *sb, struct inode *parent,
for (i = 0; i < ngroups; i++) { for (i = 0; i < ngroups; i++) {
grp = (parent_group + i) % ngroups; grp = (parent_group + i) % ngroups;
desc = ext4_get_group_desc(sb, grp, NULL); desc = ext4_get_group_desc(sb, grp, NULL);
grp_free = ext4_free_inodes_count(sb, desc); if (desc) {
if (desc && grp_free && grp_free >= avefreei) { grp_free = ext4_free_inodes_count(sb, desc);
*group = grp; if (grp_free && grp_free >= avefreei) {
return 0; *group = grp;
return 0;
}
} }
} }