Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

USB-SIS: Deletion of an unnecessary check before the function call "usb_put_dev"

Browse source 
The usb_put_dev() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Markus Elfring 2014-11-21 15:50:44 +01:00 • committed by Greg Kroah-Hartman
parent 03f3df817d
commit bb2d43e091
1 changed files with 1 additions and 2 deletions

3
drivers/usb/misc/sisusbvga/sisusb.c
View file

@ -2472,8 +2472,7 @@ sisusb_delete(struct kref *kref)
if (!sisusb)
return;
if (sisusb->sisusb_dev)
usb_put_dev(sisusb->sisusb_dev);
usb_put_dev(sisusb->sisusb_dev);
sisusb->sisusb_dev = NULL;
sisusb_free_buffers(sisusb);