Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] sys_set_mempolicy() doesnt check if mode < 0

Browse source 
A kernel BUG() is triggered by a call to set_mempolicy() with a negative
first argument.  This is because the mode is declared as an int, and the
validity check doesnt check < 0 values.  Alternatively, mode could be
declared as unsigned int or unsigned long.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Eric Dumazet 2005-08-01 21:11:43 -07:00 committed by Linus Torvalds
parent 690dbe1ced
commit ba17101b41
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
mm/mempolicy.c
View file

@ -443,7 +443,7 @@ asmlinkage long sys_set_mempolicy(int mode, unsigned long __user *nmask,
struct mempolicy *new; struct mempolicy *new;
DECLARE_BITMAP(nodes, MAX_NUMNODES); DECLARE_BITMAP(nodes, MAX_NUMNODES);
if (mode > MPOL_MAX) if (mode < 0 || mode > MPOL_MAX)
return -EINVAL; return -EINVAL;
err = get_nodes(nodes, nmask, maxnode, mode); err = get_nodes(nodes, nmask, maxnode, mode);
if (err) if (err)