Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] ipcsem: remove superflous decrease variable from sys_semtimedop

Browse source 
Patrick noticed that the initial scan of the semaphore operations logs
decrease and increase operations seperately, but then both cases are or'ed
together and decrease is never used.  The attached patch removes the
decrease parameter - it shrinks sys_semtimedop() by 56 bytes.

Signed-Of-By: Manfred Spraul <manfred@colorfullife.com>

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Manfred Spraul 2005-06-23 00:10:06 -07:00 committed by Linus Torvalds
parent 0030cbf06c
commit b78755abcd
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ipc/sem.c
View file

@ -1054,7 +1054,7 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
struct sembuf fast_sops[SEMOPM_FAST]; struct sembuf fast_sops[SEMOPM_FAST];
struct sembuf* sops = fast_sops, *sop; struct sembuf* sops = fast_sops, *sop;
struct sem_undo *un; struct sem_undo *un;
int undos = 0, decrease = 0, alter = 0, max; int undos = 0, alter = 0, max;
struct sem_queue queue; struct sem_queue queue;
unsigned long jiffies_left = 0; unsigned long jiffies_left = 0;
@ -1089,13 +1089,10 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
if (sop->sem_num >= max) if (sop->sem_num >= max)
max = sop->sem_num; max = sop->sem_num;
if (sop->sem_flg & SEM_UNDO) if (sop->sem_flg & SEM_UNDO)
undos++; undos = 1;
if (sop->sem_op < 0) if (sop->sem_op != 0)
decrease = 1;
if (sop->sem_op > 0)
alter = 1; alter = 1;
} }
alter |= decrease;
retry_undos: retry_undos:
if (undos) { if (undos) {