Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

dynamic_debug: early return if _ddebug table is empty

Browse source 
If _ddebug table is empty (in a CONFIG_DYNAMIC_DEBUG build this
shouldn't happen), then warn (error?) and return early.  This skips
empty table scan and parsing of setup-string, including the pr_info
call noting the parse.  By inspection, copy return-code handling from
1st ddebug_add_module() callsite to 2nd.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Jim Cromie 2011-12-19 17:12:54 -05:00 committed by Greg Kroah-Hartman
parent 820874c75e
commit b5b78f8385
1 changed files with 21 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
lib/dynamic_debug.c
View file

@ -871,23 +871,28 @@ static int __init dynamic_debug_init(void)
int ret = 0; int ret = 0;
int n = 0; int n = 0;
if (__start___verbose != __stop___verbose) { if (__start___verbose == __stop___verbose) {
iter = __start___verbose; pr_warn("_ddebug table is empty in a "
modname = iter->modname; "CONFIG_DYNAMIC_DEBUG build");
iter_start = iter; return 1;
for (; iter < __stop___verbose; iter++) {
if (strcmp(modname, iter->modname)) {
ret = ddebug_add_module(iter_start, n, modname);
if (ret)
goto out_free;
n = 0;
modname = iter->modname;
iter_start = iter;
}
n++;
}
ret = ddebug_add_module(iter_start, n, modname);
} }
iter = __start___verbose;
modname = iter->modname;
iter_start = iter;
for (; iter < __stop___verbose; iter++) {
if (strcmp(modname, iter->modname)) {
ret = ddebug_add_module(iter_start, n, modname);
if (ret)
goto out_free;
n = 0;
modname = iter->modname;
iter_start = iter;
}
n++;
}
ret = ddebug_add_module(iter_start, n, modname);
if (ret)
goto out_free;
/* ddebug_query boot param got passed -> set it up */ /* ddebug_query boot param got passed -> set it up */
if (ddebug_setup_string[0] != '\0') { if (ddebug_setup_string[0] != '\0') {