Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

net/ax25: Use available error codes

Browse source 
Error codes are stored in err, but the return value is always 0.  Return
err instead.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Julia Lawall 2010-08-16 06:26:57 +00:00 committed by David S. Miller
parent 636b8116d4
commit b3d18f1509
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
net/ax25/ax25_route.c
View file

@ -412,7 +412,7 @@ int ax25_rt_autobind(ax25_cb *ax25, ax25_address *addr)
{ {
ax25_uid_assoc *user; ax25_uid_assoc *user;
ax25_route *ax25_rt; ax25_route *ax25_rt;
int err; int err = 0;
if ((ax25_rt = ax25_get_route(addr, NULL)) == NULL) if ((ax25_rt = ax25_get_route(addr, NULL)) == NULL)
return -EHOSTUNREACH; return -EHOSTUNREACH;
@ -453,7 +453,7 @@ int ax25_rt_autobind(ax25_cb *ax25, ax25_address *addr)
put: put:
ax25_put_route(ax25_rt); ax25_put_route(ax25_rt);
return 0; return err;
} }
struct sk_buff *ax25_rt_build_path(struct sk_buff *skb, ax25_address *src, struct sk_buff *ax25_rt_build_path(struct sk_buff *skb, ax25_address *src,