usb: musb: omap2430: fix wrong devm_kzalloc() result check
Commit 00a0b1d58a
(usb: musb: omap: Add device
tree support for omap musb glue) assigns result of devm_kzalloc() call to
the 'config' variable but then checks for NULL the 'data' variable (already
checked after previous call). Thus we risk a kernel oops further when data
pointed by 'config' is written to by subsequent of_property_read_u32() calls
iff the allocation happens to fail...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
parent
25736e0c82
commit
b37457d80b
1 changed files with 1 additions and 1 deletions
|
@ -543,7 +543,7 @@ static int omap2430_probe(struct platform_device *pdev)
|
|||
}
|
||||
|
||||
config = devm_kzalloc(&pdev->dev, sizeof(*config), GFP_KERNEL);
|
||||
if (!data) {
|
||||
if (!config) {
|
||||
dev_err(&pdev->dev,
|
||||
"failed to allocate musb hdrc config\n");
|
||||
goto err2;
|
||||
|
|
Loading…
Add table
Reference in a new issue