Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

rtc: fix module reference count in rtc-proc

Browse source 
rtc-proc.c is not built as a module. Thus, rather than dealing with
THIS_MODULE's reference count, we should deal with rtc->owner's
reference count.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
This commit is contained in:
Geliang Tang 2015-11-07 12:00:21 +08:00 committed by Alexandre Belloni
parent fbbf53f702
commit b01079be44
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/rtc/rtc-proc.c
View file

@ -112,19 +112,21 @@ static int rtc_proc_open(struct inode *inode, struct file *file)
int ret; int ret;
struct rtc_device *rtc = PDE_DATA(inode); struct rtc_device *rtc = PDE_DATA(inode);
if (!try_module_get(THIS_MODULE)) if (!try_module_get(rtc->owner))
return -ENODEV; return -ENODEV;
ret = single_open(file, rtc_proc_show, rtc); ret = single_open(file, rtc_proc_show, rtc);
if (ret) if (ret)
module_put(THIS_MODULE); module_put(rtc->owner);
return ret; return ret;
} }
static int rtc_proc_release(struct inode *inode, struct file *file) static int rtc_proc_release(struct inode *inode, struct file *file)
{ {
int res = single_release(inode, file); int res = single_release(inode, file);
module_put(THIS_MODULE); struct rtc_device *rtc = PDE_DATA(inode);
module_put(rtc->owner);
return res; return res;
} }