Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mfd: mc12xx-i2c: rtsx_pcr: ti-ssp: Remove redundant dev_set_drvdata

Browse source 
Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Sachin Kamat 2013-09-20 14:19:34 +05:30 committed by Lee Jones
parent bef7816176
commit af1192d769
3 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/mfd/mc13xxx-i2c.c
View file

@ -78,7 +78,6 @@ static int mc13xxx_i2c_probe(struct i2c_client *client,
ret = PTR_ERR(mc13xxx->regmap); ret = PTR_ERR(mc13xxx->regmap);
dev_err(mc13xxx->dev, "Failed to initialize register map: %d\n", dev_err(mc13xxx->dev, "Failed to initialize register map: %d\n",
ret); ret);
dev_set_drvdata(&client->dev, NULL);
return ret; return ret;
} }

5
drivers/mfd/rtsx_pcr.c
View file

@ -1149,7 +1149,7 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
pcr->remap_addr = ioremap_nocache(base, len); pcr->remap_addr = ioremap_nocache(base, len);
if (!pcr->remap_addr) { if (!pcr->remap_addr) {
ret = -ENOMEM; ret = -ENOMEM;
goto free_host; goto free_handle;
} }
pcr->rtsx_resv_buf = dma_alloc_coherent(&(pcidev->dev), pcr->rtsx_resv_buf = dma_alloc_coherent(&(pcidev->dev),
@ -1209,8 +1209,6 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
pcr->rtsx_resv_buf, pcr->rtsx_resv_buf_addr); pcr->rtsx_resv_buf, pcr->rtsx_resv_buf_addr);
unmap: unmap:
iounmap(pcr->remap_addr); iounmap(pcr->remap_addr);
free_host:
dev_set_drvdata(&pcidev->dev, NULL);
free_handle: free_handle:
kfree(handle); kfree(handle);
free_pcr: free_pcr:
@ -1242,7 +1240,6 @@ static void rtsx_pci_remove(struct pci_dev *pcidev)
pci_disable_msi(pcr->pci); pci_disable_msi(pcr->pci);
iounmap(pcr->remap_addr); iounmap(pcr->remap_addr);
dev_set_drvdata(&pcidev->dev, NULL);
pci_release_regions(pcidev); pci_release_regions(pcidev);
pci_disable_device(pcidev); pci_disable_device(pcidev);

1
drivers/mfd/ti-ssp.c
View file

@ -445,7 +445,6 @@ static int ti_ssp_remove(struct platform_device *pdev)
iounmap(ssp->regs); iounmap(ssp->regs);
release_mem_region(ssp->res->start, resource_size(ssp->res)); release_mem_region(ssp->res->start, resource_size(ssp->res));
kfree(ssp); kfree(ssp);
dev_set_drvdata(dev, NULL);
return 0; return 0;
} }