Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

printk: remove bounds checking for log_prefix

Browse source 
Currently log_prefix is testing that the first character of the log level
and facility is less than '0' and greater than '9' (which is always
false).

Since the code being updated works because strtoul bombs out (endp isn't
updated) and 0 is returned anyway just remove the check and don't change
the behavior of the function.

Signed-off-by: William Douglas <william.douglas@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
William Douglas 2011-10-31 17:11:31 -07:00 committed by Linus Torvalds
parent 48e41899e4
commit ae29bc92da
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
kernel/printk.c
View file

@ -595,9 +595,6 @@ static size_t log_prefix(const char *p, unsigned int *level, char *special)
/* multi digit including the level and facility number */ /* multi digit including the level and facility number */
char *endp = NULL; char *endp = NULL;
if (p[1] < '0' || p[1] > '9')
return 0;
lev = (simple_strtoul(&p[1], &endp, 10) & 7); lev = (simple_strtoul(&p[1], &endp, 10) & 7);
if (endp == NULL || endp[0] != '>') if (endp == NULL || endp[0] != '>')
return 0; return 0;