Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Audit: do not print error when LSMs disabled

Browse source 
RHBZ: 785936

If the audit system collects a record about one process sending a signal
to another process it includes in that collection the 'secid' or 'an int
used to represet an LSM label.'  If there is no LSM enabled it will
collect a 0.  The problem is that when we attempt to print that record
we ask the LSM to convert the secid back to a string.  Since there is no
LSM it returns EOPNOTSUPP.

Most code in the audit system checks if the secid is 0 and does not
print LSM info in that case.  The signal information code however forgot
that check.  Thus users will see a message in syslog indicating that
converting the sid to string failed.  Add the right check.

Signed-off-by: Eric Paris <eparis@redhat.com>
This commit is contained in:
Eric Paris 2012-10-23 08:58:35 -04:00
parent f7616102d6
commit ad395abece
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
kernel/auditsc.c
View file

@ -1205,12 +1205,14 @@ static int audit_log_pid_context(struct audit_context *context, pid_t pid,
audit_log_format(ab, "opid=%d oauid=%d ouid=%d oses=%d", pid, audit_log_format(ab, "opid=%d oauid=%d ouid=%d oses=%d", pid,
from_kuid(&init_user_ns, auid), from_kuid(&init_user_ns, auid),
from_kuid(&init_user_ns, uid), sessionid); from_kuid(&init_user_ns, uid), sessionid);
if (security_secid_to_secctx(sid, &ctx, &len)) { if (sid) {
audit_log_format(ab, " obj=(none)"); if (security_secid_to_secctx(sid, &ctx, &len)) {
rc = 1; audit_log_format(ab, " obj=(none)");
} else { rc = 1;
audit_log_format(ab, " obj=%s", ctx); } else {
security_release_secctx(ctx, len); audit_log_format(ab, " obj=%s", ctx);
security_release_secctx(ctx, len);
}
} }
audit_log_format(ab, " ocomm="); audit_log_format(ab, " ocomm=");
audit_log_untrustedstring(ab, comm); audit_log_untrustedstring(ab, comm);