Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Blackfin: fix read buffer overflow

Browse source 
Check whether index is within bounds before testing the element.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
This commit is contained in:
Roel Kluin 2009-08-02 14:26:48 +02:00 committed by Mike Frysinger
parent 0e101ec12e
commit ac860751eb
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
arch/blackfin/kernel/bfin_dma_5xx.c
View file

@ -147,8 +147,8 @@ EXPORT_SYMBOL(request_dma);
int set_dma_callback(unsigned int channel, irq_handler_t callback, void *data) int set_dma_callback(unsigned int channel, irq_handler_t callback, void *data)
{ {
BUG_ON(!(dma_ch[channel].chan_status != DMA_CHANNEL_FREE BUG_ON(channel >= MAX_DMA_CHANNELS ||
&& channel < MAX_DMA_CHANNELS)); dma_ch[channel].chan_status == DMA_CHANNEL_FREE);
if (callback != NULL) { if (callback != NULL) {
int ret; int ret;
@ -182,8 +182,8 @@ static void clear_dma_buffer(unsigned int channel)
void free_dma(unsigned int channel) void free_dma(unsigned int channel)
{ {
pr_debug("freedma() : BEGIN \n"); pr_debug("freedma() : BEGIN \n");
BUG_ON(!(dma_ch[channel].chan_status != DMA_CHANNEL_FREE BUG_ON(channel >= MAX_DMA_CHANNELS ||
&& channel < MAX_DMA_CHANNELS)); dma_ch[channel].chan_status == DMA_CHANNEL_FREE);
/* Halt the DMA */ /* Halt the DMA */
disable_dma(channel); disable_dma(channel);