Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

3c59x: Fix deadlock between boomerang_interrupt and boomerang_start_tx

Browse source 
If netconsole is in use, there is a possibility for deadlock in 3c59x between
boomerang_interrupt and boomerang_start_xmit.  Both routines take the vp->lock,
and if netconsole is in use, a pr_* call from the boomerang_interrupt routine
will result in the netconsole code attempting to trnasmit an skb, which can try
to take the same spin lock, resulting in deadlock.

The fix is pretty straightforward.  This patch allocats a bit in the 3c59x
private structure to indicate that its handling an interrupt.  If we get into
the transmit routine and that bit is set, we can be sure that we have recursed
and will deadlock if we continue, so instead we just return NETDEV_TX_BUSY, so
the stack requeues the skb to try again later.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Neil Horman 2010-08-11 05:12:57 +00:00 committed by David S. Miller
parent bf82791ed6
commit aa25ab7d94
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/net/3c59x.c
View file

@ -633,7 +633,8 @@ struct vortex_private {
open:1, open:1,
medialock:1, medialock:1,
must_free_region:1, /* Flag: if zero, Cardbus owns the I/O region */ must_free_region:1, /* Flag: if zero, Cardbus owns the I/O region */
large_frames:1; /* accept large frames */ large_frames:1, /* accept large frames */
handling_irq:1; /* private in_irq indicator */
int drv_flags; int drv_flags;
u16 status_enable; u16 status_enable;
u16 intr_enable; u16 intr_enable;
@ -2133,6 +2134,15 @@ boomerang_start_xmit(struct sk_buff *skb, struct net_device *dev)
dev->name, vp->cur_tx); dev->name, vp->cur_tx);
} }
/*
* We can't allow a recursion from our interrupt handler back into the
* tx routine, as they take the same spin lock, and that causes
* deadlock. Just return NETDEV_TX_BUSY and let the stack try again in
* a bit
*/
if (vp->handling_irq)
return NETDEV_TX_BUSY;
if (vp->cur_tx - vp->dirty_tx >= TX_RING_SIZE) { if (vp->cur_tx - vp->dirty_tx >= TX_RING_SIZE) {
if (vortex_debug > 0) if (vortex_debug > 0)
pr_warning("%s: BUG! Tx Ring full, refusing to send buffer.\n", pr_warning("%s: BUG! Tx Ring full, refusing to send buffer.\n",
@ -2335,11 +2345,13 @@ boomerang_interrupt(int irq, void *dev_id)
ioaddr = vp->ioaddr; ioaddr = vp->ioaddr;
/* /*
* It seems dopey to put the spinlock this early, but we could race against vortex_tx_timeout * It seems dopey to put the spinlock this early, but we could race against vortex_tx_timeout
* and boomerang_start_xmit * and boomerang_start_xmit
*/ */
spin_lock(&vp->lock); spin_lock(&vp->lock);
vp->handling_irq = 1;
status = ioread16(ioaddr + EL3_STATUS); status = ioread16(ioaddr + EL3_STATUS);
@ -2447,6 +2459,7 @@ boomerang_interrupt(int irq, void *dev_id)
pr_debug("%s: exiting interrupt, status %4.4x.\n", pr_debug("%s: exiting interrupt, status %4.4x.\n",
dev->name, status); dev->name, status);
handler_exit: handler_exit:
vp->handling_irq = 0;
spin_unlock(&vp->lock); spin_unlock(&vp->lock);
return IRQ_HANDLED; return IRQ_HANDLED;
} }