Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fs: correct SuS compliance for open of large file without options

Browse source 
The early LFS work that Linux uses favours EFBIG in various places. SuSv3
specifically uses EOVERFLOW for this as noted by Michael (Bug 7253)

[EOVERFLOW]
    The named file is a regular file and the size of the file cannot be
represented correctly in an object of type off_t. We should therefore
transition to the proper error return code

Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Theodore Tso <tytso@mit.edu>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Arjan van de Ven <arjan@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alan Cox 2007-10-16 23:30:22 -07:00 committed by Linus Torvalds
parent 28e3fed8b7
commit a9c62a18a2
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
fs/gfs2/ops_file.c
View file

@ -406,7 +406,7 @@ static int gfs2_open(struct inode *inode, struct file *file)
if (!(file->f_flags & O_LARGEFILE) && if (!(file->f_flags & O_LARGEFILE) &&
ip->i_di.di_size > MAX_NON_LFS) { ip->i_di.di_size > MAX_NON_LFS) {
error = -EFBIG; error = -EOVERFLOW;
goto fail_gunlock; goto fail_gunlock;
} }

2
fs/ntfs/file.c
View file

@ -61,7 +61,7 @@ static int ntfs_file_open(struct inode *vi, struct file *filp)
{ {
if (sizeof(unsigned long) < 8) { if (sizeof(unsigned long) < 8) {
if (i_size_read(vi) > MAX_LFS_FILESIZE) if (i_size_read(vi) > MAX_LFS_FILESIZE)
return -EFBIG; return -EOVERFLOW;
} }
return generic_file_open(vi, filp); return generic_file_open(vi, filp);
} }

2
fs/open.c
View file

@ -1177,7 +1177,7 @@ asmlinkage long sys_vhangup(void)
int generic_file_open(struct inode * inode, struct file * filp) int generic_file_open(struct inode * inode, struct file * filp)
{ {
if (!(filp->f_flags & O_LARGEFILE) && i_size_read(inode) > MAX_NON_LFS) if (!(filp->f_flags & O_LARGEFILE) && i_size_read(inode) > MAX_NON_LFS)
return -EFBIG; return -EOVERFLOW;
return 0; return 0;
} }