Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

perf ui progress: Fix progress update

Browse source 
We currently update the 'next' variable only with a single step value.
But it's possible the 'adv' update is bigger than single 'step' value.
This would leave 'next' value under counted and force unnecessary
ui_progress__ops->update calls.

Calculate the amount of steps we need for 'adv' update and increase the
'next' with that amounts of steps.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20170908120510.22515-3-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Jiri Olsa 2017-09-08 14:05:08 +02:00 committed by Arnaldo Carvalho de Melo
parent 4d286c89e4
commit a82bfd041d
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tools/perf/ui/progress.c
View file

@ -1,3 +1,4 @@
#include <linux/kernel.h>
#include "../cache.h" #include "../cache.h"
#include "progress.h" #include "progress.h"
@ -14,10 +15,14 @@ struct ui_progress_ops *ui_progress__ops = &null_progress__ops;
void ui_progress__update(struct ui_progress *p, u64 adv) void ui_progress__update(struct ui_progress *p, u64 adv)
{ {
u64 last = p->curr;
p->curr += adv; p->curr += adv;
if (p->curr >= p->next) { if (p->curr >= p->next) {
p->next += p->step; u64 nr = DIV_ROUND_UP(p->curr - last, p->step);
p->next += nr * p->step;
ui_progress__ops->update(p); ui_progress__ops->update(p);
} }
} }